Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-998036: Add check if command text is set before executing #861

Merged
merged 3 commits into from
Feb 14, 2024
Merged

SNOW-998036: Add check if command text is set before executing #861

merged 3 commits into from
Feb 14, 2024

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Add check if command text is set before executing

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d478f0) 83.93% compared to head (99b11cf) 84.52%.
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
+ Coverage   83.93%   84.52%   +0.59%     
==========================================
  Files          89       92       +3     
  Lines        9313     9585     +272     
  Branches      859      892      +33     
==========================================
+ Hits         7817     8102     +285     
+ Misses       1272     1254      -18     
- Partials      224      229       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review February 10, 2024 01:08
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner February 10, 2024 01:08
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Feb 11, 2024
Closed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit 6be56bb into master Feb 14, 2024
22 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-998036-Command-Text branch February 14, 2024 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-ext-simba-lf @sfc-gh-knozderko @sfc-gh-mhofman